Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update axios to resolve follow-redirects CVE-2024-28849 #10291

Merged
merged 3 commits into from
Mar 18, 2024
Merged

chore: Update axios to resolve follow-redirects CVE-2024-28849 #10291

merged 3 commits into from
Mar 18, 2024
+21 −11

Conversation

bnussman-akamai
Copy link
Member

@bnussman-akamai bnussman-akamai commented Mar 18, 2024 •
edited
Loading

Description 📝

Preview 📷

Before After
Screenshot 2024-03-18 at 10 02 55 AM Screenshot 2024-03-18 at 10 01 55 AM

How to test 🧪

  • Checkout this PR
  • Run yarn for good measure (installs dependencies)
  • Run yarn why follow-redirects and verify we are on follow-redirects >= 1.15.6

As an Author I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@bnussman-akamai bnussman-akamai added the Dependencies Pull requests that update a dependency file label Mar 18, 2024
@bnussman-akamai bnussman-akamai self-assigned this Mar 18, 2024
@bnussman-akamai bnussman-akamai requested a review from a team as a code owner March 18, 2024 14:05
@bnussman-akamai bnussman-akamai requested review from jdamore-linode and mjac0bs and removed request for a team March 18, 2024 14:05
@bnussman-akamai bnussman-akamai mentioned this pull request Mar 18, 2024
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 18, 2024 •
edited
Loading

Coverage Report: ✅
Base Coverage: 81.42%
Current Coverage: 81.42%

mjac0bs
mjac0bs approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified 1.15.6. Thanks for updating!

@mjac0bs mjac0bs added the Approved Multiple approvals and ready to merge! label Mar 18, 2024
@bnussman-akamai bnussman-akamai merged commit 888cc13 into linode:develop Mar 18, 2024
18 checks passed
This was referenced Mar 28, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjac0bs mjac0bs mjac0bs approved these changes

@jdamore-linode jdamore-linode jdamore-linode approved these changes

Assignees

@bnussman-akamai bnussman-akamai

Labels
Approved Multiple approvals and ready to merge! Dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bnussman-akamai @jdamore-linode @mjac0bs @bnussman